Skip to content

Move information to workspace and specify MSRV #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2025

Conversation

oscargus
Copy link
Contributor

Minimum supported rustc version (MSRV) was not provided. Also, it is more convenient to have shared info in the workspace Cargo.toml.

MSRV is 1.82 for the library (because of iter::repeat_n), but the use of brunch 0.9 require 1.85. As this is a test dependency, I decided to downgrade to 0.8 to keep MSRV a bit lower than the latest. Updating to 1.85 is now easier as that will also require updating to edition to 2024, which can be done in a single location.

In general, specifying version with "0" is a source for issues since it is OK to have breaking API changes for minor versions if major version is "0". For major version 1 and higher, there should be no breaking API changes without changing major version. I didn't specify a version for the crates that has "0" though (except for brunch then). The drawback is that cargo will not automatically update minor versions for major version "0", so this will have to be done manually. Still, it is probably better to update manually rather than breaking it. (Or at least specify that --locked should be used when building locally.)

Finally, I also changed the repository to point to the "correct"(?) one (although there is a redirect).

One may consider moving the dependencies to using the workspace as well, but there weren't that many shared dependencies (and since the version specification is pretty wide it may not give that much of a benefit anyway).

@Schottkyc137
Copy link
Contributor

Thanks! Those changes all look good and make sense to me 👍

@Schottkyc137 Schottkyc137 merged commit 0c17243 into VHDL-LS:master Apr 22, 2025
10 checks passed
@oscargus oscargus deleted the wsinfo branch April 23, 2025 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants