Move information to workspace and specify MSRV #376
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minimum supported rustc version (MSRV) was not provided. Also, it is more convenient to have shared info in the workspace Cargo.toml.
MSRV is 1.82 for the library (because of
iter::repeat_n
), but the use of brunch 0.9 require 1.85. As this is a test dependency, I decided to downgrade to 0.8 to keep MSRV a bit lower than the latest. Updating to 1.85 is now easier as that will also require updating to edition to 2024, which can be done in a single location.In general, specifying version with "0" is a source for issues since it is OK to have breaking API changes for minor versions if major version is "0". For major version 1 and higher, there should be no breaking API changes without changing major version. I didn't specify a version for the crates that has "0" though (except for brunch then). The drawback is that cargo will not automatically update minor versions for major version "0", so this will have to be done manually. Still, it is probably better to update manually rather than breaking it. (Or at least specify that
--locked
should be used when building locally.)Finally, I also changed the repository to point to the "correct"(?) one (although there is a redirect).
One may consider moving the dependencies to using the workspace as well, but there weren't that many shared dependencies (and since the version specification is pretty wide it may not give that much of a benefit anyway).