Skip to content

Conversation

@Schottkyc137
Copy link
Contributor

See #278

Now also allows variable substitution in Windows using the %VAR_NAME% syntax

@Schottkyc137
Copy link
Contributor Author

@Xcodo do you think that this is would work for Windows users?

@Xcodo
Copy link
Contributor

Xcodo commented Mar 25, 2024

Looks reasonable to me, thanks for implementing that.

I had a look at the conversation in the subst package too. I don't think %VAR_NAME% is absolutely required. %{VAR_NAME} would also likely be fine for most people as long as it is documented.

@Schottkyc137
Copy link
Contributor Author

I'll merge this for now just to be able to roll the fix for windows out. But this will likely not a very long-lived change, depending on what subst does.

@Schottkyc137 Schottkyc137 merged commit b43b96c into VHDL-LS:master Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants