Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: play sound effects first thing in onPressed methods #542

Merged
merged 1 commit into from
May 29, 2024
Merged

fix: play sound effects first thing in onPressed methods #542

merged 1 commit into from
May 29, 2024

Conversation

jsgalarraga
Copy link
Member

Description

Play sound effects first thing in the onTap methods to avoid having lag on playing the sounds

Screenshots/Video

Not applicable

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@jsgalarraga jsgalarraga self-assigned this May 29, 2024
@jsgalarraga jsgalarraga merged commit 276b2a7 into main May 29, 2024
3 checks passed
@jsgalarraga jsgalarraga deleted the fix/sfx branch May 29, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AyadLaouissi AyadLaouissi AyadLaouissi approved these changes

@B0berman B0berman Awaiting requested review from B0berman B0berman is a code owner

@alestiago alestiago Awaiting requested review from alestiago alestiago is a code owner

@marwfair marwfair Awaiting requested review from marwfair marwfair is a code owner

Assignees

@jsgalarraga jsgalarraga

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsgalarraga @AyadLaouissi