Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: replaced just_audio for audioplayers #22

Merged
merged 1 commit into from
Aug 2, 2024
Merged

refactor: replaced just_audio for audioplayers #22

merged 1 commit into from
Aug 2, 2024

Conversation

jneschisi
Copy link
Contributor

@jneschisi jneschisi commented Aug 1, 2024 •
edited
Loading

Description

Replaced music player implementation switching from just_audio to audioplayers.

With this change issue #15 is fixed.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@jneschisi jneschisi self-assigned this Aug 1, 2024
marwfair
marwfair approved these changes Aug 1, 2024
View reviewed changes
Copy link
Contributor

@marwfair marwfair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! LGTM!

@jneschisi jneschisi merged commit 792db31 into main Aug 2, 2024
3 checks passed
@jneschisi jneschisi deleted the refactor/new-audio-package branch August 2, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marwfair marwfair marwfair approved these changes

Assignees

@jneschisi jneschisi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jneschisi @marwfair