Exchange defaultProps for default parameters in function components #1226
Conversation
|
Started looking into removing |
| shouldCloseOnSelection, | ||
| wrapPopover, | ||
| currentList, | ||
| selectedList = [], |
There was a problem hiding this comment.
I don't think we need this. Isn't selectedList an option prop for CheckboxTree?
| searchTerm, | ||
| selectedList, | ||
| searchTerm = '', | ||
| selectedList = [], |
There was a problem hiding this comment.
This will create a new array on each render. Use defaultCheckboxTreeProps.selectedList to prevent that
| selectedList = [], | |
| selectedList = defaultCheckboxTreeProps.selectedList, |
| onSelectionChange = () => { | ||
| // | ||
| }, |
There was a problem hiding this comment.
| onSelectionChange = () => { | |
| // | |
| }, | |
| onSelectionChange = defaultCheckboxTreeProps.onSelectionChange, |
| onSearchTermChange = () => { | ||
| // | ||
| }, |
There was a problem hiding this comment.
| onSearchTermChange = () => { | |
| // | |
| }, | |
| onSearchTermChange = defaultCheckboxTreeProps.onSearchTermChange, |
| searchIconName, | ||
| searchIconPosition, | ||
| searchBoxHelp, | ||
| searchBoxHelp = '', | ||
| searchPredicate = () => true, |
There was a problem hiding this comment.
| searchPredicate = () => true, | |
| searchPredicate = defaultCheckboxTreeProps.searchPredicate, |
| additionalFilters, | ||
| wrapTreeSection, | ||
| shouldExpandOnClick = true, | ||
| customCheckboxes, | ||
| customCheckboxes = {}, |
There was a problem hiding this comment.
| customCheckboxes = {}, | |
| customCheckboxes = defaultCheckboxTreeProps.customCheckboxes, |
There was a problem hiding this comment.
It occurred to me that you could do something like this in the component:
function CheckboxTree<T>(partialProps: Props<T>) {
const props = { ...defaultProps, ...partialProps };
// ...
}If a prop is defined in partialProps, it's value will be used; otherwise, the value in defaultProps will be used.
Partially resolves #1218
defaultPropsis being deprecated for function components. This PR removes the olddefaultPropsfrom all function components.Below is the list that Bob provided (for completeness). I either completed the update or found it was not a case that needed changing:
I also found
deafultPropsinCompound.jsx,Gbrowse.jsx, andOverviewThumbnail.jsxbut they were all being used with class components.Notes
SelectTree, I removed the default props entirely if they both were the same as the component they were being passed to and caused no errors when removing.CheckboxTree.tsxrelied on default values being set, so i defined them in the file and then reused these values across the different functions.Sequencecomponent on gene record pages. Where does it get loaded? Otherwise I checked all the other updated components on the genomics or mbio site.