Fix window maximization on load.....fixes #1205 and #1235 #1804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Window hint 'GLFW_MAXIMIZED' must be set before creating the window. This has the side-effect of creating a maximized window on load, however, before the window is shown it's postion and size are sett correctly.
|
Sorry, I don't do PRs for Rack. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Window hint 'GLFW_MAXIMIZED' must be set before creating the window.
This has the side-effect of creating a maximized window on load, however,
before the window is shown it's position and size are set if present in settings.
This fixes issues: #1205 and #1235