Opt-in modern protocol negotiation for stdio MCP servers - #1646
Merged
Conversation
Contributor
Cloudflare previewTorn down — the PR is closed. |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-marketing | 415e5be | Commit Preview URL Branch Preview URL |
Aug 18 2026, 03:38 AM |
@executor-js/cli
@executor-js/config
@executor-js/execution
@executor-js/sdk
@executor-js/codemode-core
@executor-js/runtime-quickjs
@executor-js/plugin-file-secrets
@executor-js/plugin-graphql
@executor-js/plugin-keychain
@executor-js/plugin-mcp
@executor-js/plugin-onepassword
@executor-js/plugin-openapi
executor
commit: |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-cloud | 415e5be | Aug 18 2026, 03:41 AM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses a user report (tested on 1.5.41): the remote Streamable HTTP client negotiates spec 2026-07-28, but spawned stdio servers always opened with the legacy 2025 initialize handshake, so an SDK v2 server with its legacy lane disabled could not connect.
Stdio integrations now accept versionNegotiation: "auto" (addServer payload, SDK input, stored config) to probe server/discover and fall back to initialize on legacy servers. The default stays legacy per the SDK's own stdio guidance: the auto probe spawns a short-lived sibling process per connect and stalls for the probe timeout on silent legacy servers, which is the wrong default for spawn-per-call CLI servers.
The connect handshake span records the negotiated era (plugin.mcp.protocol_era) so integration authors can verify modern vs legacy from traces.
Tests: stdio-negotiation.test.ts runs the report's acceptance case against a real SDK v2 server with legacy: "reject" (auto connects modern, lists and calls tools; the default handshake fails; a both-era server stays legacy by default). The stdio e2e scenario now also adds an auto-mode server and proves fallback discovery end to end.