Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPM Support #142

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

check4ismail
Copy link

No description provided.

@msmollin
Copy link

msmollin commented Aug 21, 2021

Tried to test this on my fork and while the package did successfully import, the resulting module was empty save a single import statement. I'm not a SPM expect but I'm guessing it's because we've marked UrbanApps/Armchair as an upstream dependency which won't import anything unless this repo supported SPM from the get go. (It could also be the target doesn't declare any dependencies. Like I said I'm no expert here).

That said, I don't believe we need to actually depend on anything given this codebase has no dependencies, so I rewrote the Package.swift to not depend on anything over here in my mods branch. These changes do work correctly in my app and everything compiles nicely.

Feel free to uptake these changes in your branch. I kinda flubbed a rebase at one point and so it squashed my changes into your commit accidentally @check4ismail. If you want me to open a PR against your fork I'm happy to do so - just would need to redo my (rather small) changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants