-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: cleanup API and add pydantic models for typing #58
Conversation
Why not splitting the code by operation? E.g. that we rather have a |
I opted to mirror the way that FastAPI structures its directories. This is fine too, if we prefer that I can swap to that. |
If this new way is documented somewhere then that is ok as well. On a quick search I found these practices which are close to the new structure: https://github.com/zhanymkanov/fastapi-best-practices?tab=readme-ov-file#project-structure This would be another approach: https://stackoverflow.com/a/64987404 |
a9fbe57
to
084846a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huge rework - I like where this is going. One small thing left for this PR with the POST/PUT.
An open issue for another PR is then to remove the tenant and have the /ddi prefix.
Lastly: is the new file structure based on any documented approach how to organize such projects? If yes, reference it in the README.md. This could reduce discussions / uncertainties where to put what.
… model and API schema.
…stent function signature.
5bec892
to
c50a77e
Compare
General API and auth fixes, as well as pydantic models for most of the endpoints (except for download, because I moved it around in #47, and it cant use the models anyway). Moves things around to make it more clear what parts of the code do what.