fix: claim update slot atomically#427
Open
timkambic-ngen wants to merge 2 commits into
Open
Conversation
Contributor
Author
|
Tested this also in our production setting with lots of devices. Before it would overshoot the configured max_concurrent_updates limit of 50 by 10-15devices on new rollout trigger. |
timkambic-ngen
marked this pull request as ready for review
July 21, 2026 13:10
Member
|
Any chance we can avoid the raw SQL? If not then this is fine as is, I will approve and merge, just want a sanity check, and my SQL skills are not great. |
Contributor
Author
Dropped the raw sql and used tortoise. Looks cleaner |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on #425 I noticed the non atomic update slot handling. Which I introduced in #290
We have seen the max_concurrent_updates limit being breached quite a lot on our deployment. Especially when a new rollout is triggered and all devices compete for the slots.
This PR introduces a new state
RESERVEDwhich is atomically claimed and assigned to a device. After the device reports progress it's state is changed toRUNNING- same behavior as before.Note: I have also considered to change device's state directly to
RUNNINGas soon as the slot is claimed but it introduced quite some behavioral changes.