Fix online status ("Up") flickering bug #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The polling endpoint should choose the proper poll time and store it in the update manager (to be used by the UI). Fixes the issue that poll time was incorrectly set when software got assigned to device. Only simplifies reasoning about correct poll time handling.
b-rowan
approved these changes
Oct 26, 2024
|
@tsagadar deployed on our instance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #137
PR does two things
These two things together should get rid of the flickering.
Note: the log file handling likely needs similar changes. Will create a new ticket for the log files as it could require some discussions first.