Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle DataTables query parameters with Depends #141

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

b-rowan
Copy link
Collaborator

@b-rowan b-rowan commented Sep 23, 2024

Use Pydantic and Depends to automatically parse the DataTables AJAX request to a typed format.

Precursor to a fix required in #138, which should use query parameters to validate software compatibility.

@b-rowan b-rowan requested a review from tsagadar September 23, 2024 20:42
Use `Pydantic` and `Depends` to automatically parse the DataTables AJAX request to a typed format.

Precursor to a fix required in #138, which should use query parameters to validate software compatibility.
Copy link
Collaborator

@tsagadar tsagadar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@b-rowan b-rowan merged commit e59bc2a into master Sep 24, 2024
5 checks passed
@b-rowan b-rowan deleted the dev_datatables_parser branch September 24, 2024 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants