Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement S3-compatible storage for registry backend #90

Merged
merged 6 commits into from
Feb 9, 2023
Merged

Implement S3-compatible storage for registry backend #90

merged 6 commits into from
Feb 9, 2023

Conversation

filiptibell
Copy link
Contributor

@filiptibell filiptibell commented Jun 30, 2022

This allows the registry backend to be used with other providers than GCP. We have been using this exact implementation in our organization without issues since January (https://github.com/readysetplay/wally/commit/1b4ceef242c6bc15055ebd9ab6e0c30b0ae0e52f) with hosting and storage on DigitalOcean.

S3 storage is configured using the following env variables:
AWS_REGION_NAME - Name of the storage region to use such as us-east-1
AWS_REGION_ENDPOINT - Full url endpoint of the S3 server. Some providers only need this and not the region name, so the region name can be omitted and defaults to the same region as the rusoto library that this implementation uses.

Authorization is done using S3 standards and utilities that the rusoto library provides.

The implementation is otherwise very similar to what is already implemented in Wally with GCP.

Copy link
Member

@magnalite magnalite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good to me! I don't have a practical way to test if it works so I'm going to have to trust you or just wait for someone to test it in the real world and report any issues.

Seeing the above comment I think it would set a good precedent if we broke out requiring s3 into a feature flag!

@magnalite magnalite merged commit 67555bb into UpliftGames:main Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants