Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Path Dependencies #88

Open
wants to merge 29 commits into
base: main
Choose a base branch
from
Open

Add Path Dependencies #88

Changes from 1 commit
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
5c449aa
started?
u-train Jun 8, 2022
5848f25
Added test for path dependency
u-train Jun 9, 2022
d495aaa
the first stable working thing.
u-train Jun 9, 2022
c58ccf2
Stop packages using path package locations
u-train Jun 9, 2022
ab84f4b
Adding comments explaining some reasoning.
u-train Jun 9, 2022
db2f170
Added more of clippy's suggestions
u-train Jun 9, 2022
ccde971
Cleaned up with .all() instead of using .filter()
u-train Jun 9, 2022
fc4db25
More clippy business
u-train Jun 9, 2022
ec71c39
Cleaned crate::package_origin usage in match
u-train Jun 9, 2022
187f37b
Missed last
u-train Jun 9, 2022
7d895e3
More documentation
u-train Jun 9, 2022
59b6633
Added todo wrt relative paths
u-train Jun 9, 2022
e7b90b9
Cleaned up code for installation and forward-slash!
u-train Jun 9, 2022
1ab2d9d
Should be using package_id ...
u-train Jun 9, 2022
b3497cc
resolve now accepts a root_dir
u-train Jun 9, 2022
ec87fe7
Forgot to implement serializatoin for all origins
u-train Jun 11, 2022
d4a1312
Hacky way to make reoslution responsible for path
u-train Jun 11, 2022
008eb1b
Simplify leak
u-train Jun 12, 2022
7175e88
Fixed bug where it forgets to join relative path
u-train Jun 12, 2022
a8c8079
Add a new test-case for path dependencies
u-train Jun 12, 2022
0968a28
Cleaned up code
u-train Jun 12, 2022
cd51129
Use fs+path/here instead of just the path
u-train Jun 13, 2022
1815203
Added check to prevent any unexpected path dependencies
u-train Jun 13, 2022
4f3b324
Added check in backend and added publish test
u-train Jun 15, 2022
2c4d153
Changed readme with fs format
u-train Jun 15, 2022
b63ad47
CRLF to LF !!!!
u-train Jun 15, 2022
87a6e36
more CRLF to LF.. Windows!!!
u-train Jun 15, 2022
417da72
Fix gitattribute
u-train Feb 10, 2023
96b4c01
Reset to capture the files with wrong newlines.
u-train Feb 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Cleaned crate::package_origin usage in match
  • Loading branch information
@u-train
u-train committed Jun 9, 2022
commit ec71c39c02038b0c382885f356a6338848ca049a
6 changes: 3 additions & 3 deletions src/installation.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ use pathdiff::diff_paths;

use crate::{
manifest::Realm, package_contents::PackageContents, package_id::PackageId,
package_source::PackageSourceMap, resolution::Resolve,
package_origin::PackageOrigin, package_source::PackageSourceMap, resolution::Resolve,
};

pub struct InstallationContext {
Expand Down Expand Up @@ -116,8 +116,8 @@ impl InstallationContext {
}

match &resolved.metadata[package_id].package_origin {
crate::package_origin::PackageOrigin::Git(_) => todo!(),
crate::package_origin::PackageOrigin::Path(path_to_package) => {
PackageOrigin::Git(_) => todo!(),
PackageOrigin::Path(path_to_package) => {
let mut path = match package_realm {
Realm::Shared => self.shared_index_dir.clone(),
Realm::Server => self.server_index_dir.clone(),
Expand Down