Generate server->shared cross realm links #38
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to reduce the number of packages we have in the datamodel, primarily this means keeping only one copy of each package. Some packages in the server realm will depend on shared packages, however due to this optimisation they will be held in separate locations in the datamodel.
To allow server packages to require shared packages we can generate links which reference across realms. This is notable because we cannot generate these links as relative paths. We also don't know the absolute location of where shared packages are as Rojo manages their location.
In order to know where the shared packages are to generate these cross realm links an additional field has been added to the wally.toml. As an example the wally.toml may look like this.
I see it fit to put this in the "place" table to emphasise this is metadata describing the place it will be sync'd into and not information related to the package itself. This can also be where we add any further metadata about where the package will be sync'd we may require.