Draft
Conversation
quarium
force-pushed
the
upipe_interlace
branch
2 times, most recently
from
59d7ace to
41213f1
Compare
Change uref_pic_progressive and uref_pic_tff attributes from void to boolean. With void attribute, there is no possibility to explicitly set interlaced or bottom field first on a flow definition packet.
quarium
force-pushed
the
upipe_interlace
branch
from
41213f1 to
b3ef35b
Compare
Add upipe_interlace pipe to preform temporal field interlacing.
quarium
force-pushed
the
upipe_interlace
branch
from
b3ef35b to
72dfc5c
Compare
nto
requested changes
Feb 2, 2026
| * @return an error code | ||
| */ | ||
| static int upipe_interlace_set_option(struct upipe *upipe, const char *option, | ||
| const char *value) |
Collaborator
There was a problem hiding this comment.
The SET_OPTION control command should only be used to pass string parameters to an underlying API. Standard parameters are to be implemented using dedicated control commands, otherwise they are inconvenient to use since native values cannot be used and static typing is gone.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add upipe_interlace pipe to preform temporal field interlacing.