feat: new partitioning brick that calls the document image analysis API #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MthwRobinson
suggested changes
Nov 16, 2022
There was a problem hiding this comment.
Functionality looks great! I liked the healtcheck too. Just a couple of minor comments on the code. Could you also add documentation for this brick to bricks.rst under docs? You can run make html under the docs folder to regenerate the docs, once you've installed docs/requirements.txt.
unstructured/nlp/partition.py
Outdated
| if not token: | ||
| healthcheck_response = requests.get(url=f"{url}healthcheck") | ||
|
|
||
| if healthcheck_response.status_code == 200: |
There was a problem hiding this comment.
To avoid the nested ifs, can we check for != 200 instead?
MthwRobinson
approved these changes
Nov 16, 2022
docs/source/bricks.rst
Outdated
| @@ -174,6 +174,23 @@ Examples: | |||
|
|
|||
| # Returns False because the text is more than 1% caps | |||
| exceeds_cap_ratio(example_2, threshold=0.01) | |||
|
|
|||
|
|
|||
| ``partition_pfd`` | |||
There was a problem hiding this comment.
Suggested change
| ``partition_pfd`` | |
| ``partition_pdf`` |
docs/source/bricks.rst
Outdated
| ``partition_pfd`` | ||
| --------------------- | ||
|
|
||
| The ``partition_pdf`` function calls the document image analysis API. The intent of the |
There was a problem hiding this comment.
Suggested change
| The ``partition_pdf`` function calls the document image analysis API. The intent of the | |
| The ``partition_pdf`` segments a PDF document the document image analysis API. The intent of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add a new partitioning brick partition_pfd that calls the document image analysis API to segment a PDF