ci: pin ludeeus/action-shellcheck to a full commit SHA#4396
Open
kobihikri wants to merge 1 commit into
Open
Conversation
ci.yml references this third-party action by the mutable @master tag. Pin it to the current master commit SHA (tag kept in a trailing comment) so a moved tag can't run unreviewed code in CI. Behaviour unchanged; per GitHub's guidance to pin actions to a full-length commit SHA. Signed-off-by: Kobi Hikri <kobi.hikri@gmail.com>
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
No issues found across 1 file
Shadow auto-approve: would auto-approve. Pins a third-party GitHub Action from a mutable branch to a specific commit SHA for supply-chain security. One-line change in CI workflow, no behavioral impact.
Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Pin
ludeeus/action-shellcheck@master→00b27aa…inci.yml(tag kept in a trailing comment).Why
@masteris a moving reference — whatever it points to at run time runs in CI.ci.ymlis asecret-heavy workflow (
UNS_API_KEY,HF_TOKEN, Confluence/Box/Airtable tokens, …), so removing amutable third-party ref here is worthwhile defense-in-depth: if the action's
masterwere moved(compromise or an accidental change), the new code would run in CI — the class of issue behind the 2025
tj-actions/changed-filesincident. Pinning to a SHA closes that.Scope / safety
master. Signed-off.Per GitHub's guidance to pin actions to a full-length commit SHA.
AI-assisted; I verified the workflow and the pinned SHA myself.