Skip to content

Chore/change lang detection logging level to avoid warning log spamming #4078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 20, 2025
Merged

Chore/change lang detection logging level to avoid warning log spamming #4078

merged 2 commits into from
Aug 20, 2025

Conversation

@badGarnet
Copy link
Collaborator

This PR changes the log line for defaulting short text to English to debug level.

  • this log is not because the logic failed or exception handling
  • short text can be common and we can get a lot of warning logs with the original code -> spams warning log and potentially cause user to miss other important warning level logs

@badGarnet badGarnet marked this pull request as draft August 20, 2025 14:07
@badGarnet badGarnet marked this pull request as ready for review August 20, 2025 15:28
@badGarnet badGarnet added this pull request to the merge queue Aug 20, 2025
Merged via the queue into main with commit 76d7a5c Aug 20, 2025
69 of 70 checks passed
@badGarnet badGarnet deleted the chore/change-lang-detection-logging-level-to-avoid-warning-log-spamming branch August 20, 2025 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qued qued qued approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@badGarnet @qued