Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Fix parse received data #143

Merged
merged 14 commits into from
Jan 17, 2023
Merged

chore: Fix parse received data #143

merged 14 commits into from
Jan 17, 2023

Conversation

mallorih
Copy link
Contributor

The _parse_received_data function current returns None when the datetimestamp variable is set. This PR fixes this bug.

@mallorih mallorih changed the title bug: Fix parse received data chore: Fix parse received data Jan 11, 2023
@mallorih mallorih requested a review from MthwRobinson January 11, 2023 23:19
MthwRobinson
MthwRobinson reviewed Jan 12, 2023
View reviewed changes
Copy link
Contributor

@MthwRobinson MthwRobinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only see the changelog and version files, think you may have forgotten to push the source code changes you made.

@mallorih mallorih requested a review from MthwRobinson January 12, 2023 15:40
@mallorih
Copy link
Contributor Author

Weird, I accidentally reverted the change.

MthwRobinson
MthwRobinson suggested changes Jan 12, 2023
View reviewed changes
Copy link
Contributor

@MthwRobinson MthwRobinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look could, could you add a test too?

@mallorih mallorih requested a review from MthwRobinson January 17, 2023 22:27
@mallorih
Copy link
Contributor Author

@MthwRobinson I changed my fix in the Name class in email_elements a little and added the test.

MthwRobinson
MthwRobinson approved these changes Jan 17, 2023
View reviewed changes
Copy link
Contributor

@MthwRobinson MthwRobinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mallorih mallorih merged commit 08ccee0 into main Jan 17, 2023
@mallorih mallorih deleted the fix-parse-received-data branch January 17, 2023 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MthwRobinson MthwRobinson MthwRobinson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mallorih @MthwRobinson