Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add new pattern for dash bullet #109

Merged
merged 3 commits into from
Dec 21, 2022
Merged

chore: add new pattern for dash bullet #109

merged 3 commits into from
Dec 21, 2022

Conversation

mallorih
Copy link
Contributor

This PR adds a new unicode character for dash - bullets, so the is_bulleted_text method can recognize plain text dashes.

Copy link
Contributor

@MthwRobinson MthwRobinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a test? Otherwise looks good once the CHANGELOG entry and version bump are in.

Copy link
Contributor

@MthwRobinson MthwRobinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending a CHANGELOG tweak

@mallorih mallorih merged commit 6f4d9ad into main Dec 21, 2022
@mallorih mallorih deleted the add-unicode-pattern branch December 21, 2022 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants