Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate CheckBox so that all Element objects are a subclass of Text #3053

Open
MthwRobinson opened this issue May 20, 2024 · 3 comments
Open

Deprecate CheckBox so that all Element objects are a subclass of Text #3053

MthwRobinson opened this issue May 20, 2024 · 3 comments
Labels
misc

Comments

@MthwRobinson
Copy link
Contributor

The goal of this issue is to deprecate the CheckBox element type, leaving all remaining Element classes as subclasses of Text. Early in the library the potential for non-text Element types was envisioned, but as the library evolved everything wound u being a subclass of Text.
@hubert-rutkowski85
Copy link
Contributor

Also a bit related (but probably deserves a new issue?), we should move the category field to Element, so that linters will not complain.
image

@MthwRobinson
Copy link
Contributor Author

Yeah agree on the category element, @hubert-rutkowski85 could you open a separate issue for that?

@hubert-rutkowski85
Copy link
Contributor

Sure! Created here #3055 and started prototyping it.

@hubert-rutkowski85 hubert-rutkowski85 mentioned this issue May 21, 2024
Merged
@scanny scanny added the misc label Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
misc
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@MthwRobinson @scanny @hubert-rutkowski85