-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: remove analysis scripts #305
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…notate OCR'd elements
…notate all types of layout elements (extracted, inferred, and final) except OCR'd elements
christinestraub
changed the title
Refactor/remove analysis scripts
Refactor: remove analysis scripts
Dec 15, 2023
christinestraub
requested review from
yuming-long,
badGarnet,
qued and
cragwolfe
December 18, 2023 18:31
…where the input param is an empty list
…out()` for the extracted layout with a full page image
scanny
approved these changes
Dec 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one suggested change but approving in advance :)
github-merge-queue bot
pushed a commit
to Unstructured-IO/unstructured
that referenced
this pull request
Dec 19, 2023
### Summary This PR is the second part of the "layout analysis" refactor to move it from unstructured-inference repo to unstructured repo, the first part is done in Unstructured-IO/unstructured-inference#305. This PR adds logic to support annotating `inferred` and `extracted` elements. ### Testing ``` PYTHONPATH=. python examples/layout-analysis/visualization.py <file_path> <strategy> <document_type> ``` e.g. ``` PYTHONPATH=. python examples/layout-analysis/visualization.py example-docs/layout-parser-paper-fast.pdf hi_res pdf ```
# Conflicts: # CHANGELOG.md # test_unstructured_inference/test_elements.py # unstructured_inference/__version__.py # unstructured_inference/utils.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is the first part of the "layout analysis" refactor to move it from unstructured-inference repo to unstructured repo. This PR removes "layout analysis" related code from unstructured-inference repo and works together with the unstructured refactor PR - Unstructured-IO/unstructured#2273.
This PR also adds a few more test cases for
layoutelement.py
to make coverage to over 95%.