fix: make sessionId be a string when set automatically #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriswk
force-pushed
the
228-post-method-fails-when-using-with-new-unleash-edge-service
branch
from
8927f2a
to
5f68477
Compare
chriswk
deleted the
228-post-method-fails-when-using-with-new-unleash-edge-service
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, all of our schemas (even our type definitions) define sessionId to be a string, however, when user does not set one, we generate one automatically as a number, and never convert it back to a string. Don't really know how Typescript allowed this to pass. I guess since we only write the id to localstorage and don't really directly return the generated number, it threw its hands up in the air and gave up.