Fix liquid adaptation and GPU crash with cap enabled #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… trace hit component. Fix liquid adaptation collision setting bReturnFaceIndex not set to true. Fix crash when enabling cap due to LiquidSahderFillCS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LiquidSahderFillCS was causing GPU crash due to OutputTexture[PixelTemp[j]] = float4(0, 0, 0, 0); so I split the algorithm in two loops.
ComputeLiquidVolume never adjusted the liquid height offset because of the missing RVectorTrace = false; if there was a hit but no material was found. The collision setting was missing bReturnFaceIndex = true so ROutHit.FaceIndex was set to -1.