-
Notifications
You must be signed in to change notification settings - Fork 128
Polyscopex dashboard client #392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Polyscopex dashboard client #392
Conversation
c661f42 to
5291e9b
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #392 +/- ##
===========================================
- Coverage 77.01% 42.78% -34.23%
===========================================
Files 92 99 +7
Lines 4328 8623 +4295
Branches 489 1170 +681
===========================================
+ Hits 3333 3689 +356
- Misses 749 4654 +3905
- Partials 246 280 +34
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
30f9749 to
0820448
Compare
9925126 to
6602e81
Compare
Add PolyScope X dashboard client aka Robot API to the client library.
Co-authored-by: Mads Holm Peters <79145214+urmahp@users.noreply.github.com>
Co-authored-by: Mads Holm Peters <79145214+urmahp@users.noreply.github.com>
This check wasn't used everywhere and it shouldn't be possible to have a DashboardClient without an impl_ as it is set in the constructor.
934001e to
d1aa744
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some very small details other than that it looks fine.
Co-authored-by: Mads Holm Peters <79145214+urmahp@users.noreply.github.com>
This adds the new Dashbaord Server called Robot API on PolyScope X 10.11.0 to the client library.
It is implemented as a drop-in replacement for the CB3 adn PolyScope 5 dashboard clients.
Note that this doesn't cover all features of the "old" Dashboard Server.