Skip to content

Conversation

@urfeex
Copy link
Member

@urfeex urfeex commented Oct 17, 2025

This adds the new Dashbaord Server called Robot API on PolyScope X 10.11.0 to the client library.

It is implemented as a drop-in replacement for the CB3 adn PolyScope 5 dashboard clients.

Note that this doesn't cover all features of the "old" Dashboard Server.

@urfeex urfeex requested a review from a team October 17, 2025 10:11
@urfeex urfeex added the enhancement New feature or request label Oct 17, 2025
@urfeex urfeex force-pushed the polyscopex_dashboard_client branch from c661f42 to 5291e9b Compare October 17, 2025 10:14
@codecov
Copy link

codecov bot commented Oct 17, 2025

Codecov Report

❌ Patch coverage is 59.20904% with 361 lines in your changes missing coverage. Please review.
✅ Project coverage is 42.78%. Comparing base (8bb50f5) to head (836aca5).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/ur/dashboard_client_implementation_g5.cpp 68.18% 152 Missing and 30 partials ⚠️
src/ur/dashboard_client_implementation_x.cpp 0.00% 120 Missing ⚠️
src/ur/dashboard_client.cpp 71.34% 35 Missing and 14 partials ⚠️
include/ur_client_library/exceptions.h 45.45% 6 Missing ⚠️
...lient_library/ur/dashboard_client_implementation.h 60.00% 2 Missing ⚠️
...ent_library/ur/dashboard_client_implementation_x.h 0.00% 1 Missing ⚠️
src/ur/ur_driver.cpp 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (8bb50f5) and HEAD (836aca5). Click for more details.

HEAD has 10 uploads less than BASE
Flag BASE (8bb50f5) HEAD (836aca5)
start_ursim 3 1
ur5e-10.7.0 3 1
ur5e-5.9.4 3 1
ur5-3.14.3 3 1
ur20-latest 3 1
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #392       +/-   ##
===========================================
- Coverage   77.01%   42.78%   -34.23%     
===========================================
  Files          92       99        +7     
  Lines        4328     8623     +4295     
  Branches      489     1170      +681     
===========================================
+ Hits         3333     3689      +356     
- Misses        749     4654     +3905     
- Partials      246      280       +34     
Flag Coverage Δ
start_ursim 81.78% <ø> (-2.24%) ⬇️
ur20-latest 40.70% <57.88%> (-34.47%) ⬇️
ur5-3.14.3 40.60% <56.50%> (-34.66%) ⬇️
ur5e-10.7.0 35.73% <14.72%> (-34.69%) ⬇️
ur5e-5.9.4 40.75% <57.88%> (-34.42%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@urfeex urfeex force-pushed the polyscopex_dashboard_client branch 2 times, most recently from 30f9749 to 0820448 Compare October 17, 2025 10:24
@urfeex urfeex force-pushed the polyscopex_dashboard_client branch from 9925126 to 6602e81 Compare October 21, 2025 13:54
@urfeex urfeex requested a review from urmahp October 22, 2025 11:51
Copy link
Contributor

@urmahp urmahp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some very small details other than that it looks fine.

Co-authored-by: Mads Holm Peters <79145214+urmahp@users.noreply.github.com>
@urfeex urfeex requested a review from urmahp October 24, 2025 04:44
@urfeex urfeex merged commit adfc196 into UniversalRobots:master Oct 24, 2025
34 of 38 checks passed
@urfeex urfeex deleted the polyscopex_dashboard_client branch October 24, 2025 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants