Remove sending an idle command in quintic spline test #275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urfeex
force-pushed
the
test_spline_interpolation_remove_idle
branch
from
809e51e to
bcc4f6f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #275 +/- ##
=======================================
Coverage 73.34% 73.34%
=======================================
Files 80 80
Lines 3181 3181
Branches 399 399
=======================================
Hits 2333 2333
Misses 627 627
Partials 221 221
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
urmahp
approved these changes
Feb 25, 2025
There was a problem hiding this comment.
To be honest I cannot remember why I introduced this. My guess would be that it was either introduced for debugging purposes or because of a delay between when the speedscaling is set in the client library and when it is applied on the robot. None of the less since the tests aren't failing I cannot see any reason not to remove it.
I don't know exactly why it was there but it could break the test quite easily since sending an idle command makes the URScript send a cancelled trajectory result sent back.
urfeex
force-pushed
the
test_spline_interpolation_remove_idle
branch
from
bcc4f6f to
1e887e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know exactly why it was there but it could break the test quite easily since sending an idle command makes the URScript send a cancelled trajectory result sent back.
@urmahp requesting a review from you as you created the
sendIdlecall initially and I don't necessarily understand why.The fact that the script sends a trajectory result when it shouldn't will be handled separately.