Skip to content

Issue135: Switching usage of the "collapsed" and "expanded" icons in the Frontend #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Koenneker
Copy link
Contributor

fixes issue #135

This PR is quite simple, it just switches the usage of the Icons around.
If the node is open, it should use the "Expanded" icon, and if it is closed, it should use the "Collapsed" icon.

Im not sure if you require any testing/ci steps, but this change should be straightforward.

@SundermannC SundermannC self-requested a review October 31, 2024 22:00
@SundermannC
Copy link
Member

Hi @Koenneker,
thanks a lot for reaching out and even providing a solution. This is highly appreciated.
I fully agree with your comments in #135 and it is very nice that the behavior is now in line with behavior of VSCode and other tools.

@SundermannC SundermannC merged commit 8a1471d into Universal-Variability-Language:master Oct 31, 2024
1 check passed
@Koenneker
Copy link
Contributor Author

Always glad to Help!
Thanks for including my changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants