Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: sync & set_var #653

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

refactor: sync & set_var #653

wants to merge 5 commits into from

Conversation

Rudxain
Copy link
Member

@Rudxain Rudxain commented Sep 24, 2024

  • Store some strings as consts, as explained here
  • Since all calls to set_var specify ANDROID_SERIAL as key, I decided to define a function for it.

Copy link
Contributor

deepsource-io bot commented Sep 24, 2024

Here's the code health analysis summary for commits e595973..63707f3. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Rust LogoRust❌ Failure
❗ 3 occurences introduced
🎯 2 occurences resolved
View Check ↗
DeepSource Test coverage LogoTest coverage⚠️ Artifact not reportedTimed out: Artifact was never reportedView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@Rudxain Rudxain added the refactor Rework of code — behaviour doesn't change label Sep 25, 2024
src/core/sync.rs Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Rework of code — behaviour doesn't change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants