-
Notifications
You must be signed in to change notification settings - Fork 10
ssh key validation #50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor code cleanup changes, other than that this looks really good, thanks!
Co-authored-by: Hakan Saplakoglu <hakansaplakog@gmail.com>
@hakasapl can you fix this one codesniffer warning? (rest of the checks are passing on my latest commit)
|
Hi, it's complaining because the function can't be in this file. Could you make that a static function and put it in this file? https://github.com/UnityHPC/unity-web-portal/blob/main/resources/lib/UnitySite.php That should resolve that issue, then you'll have to call the static function from the account page |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
PublicKeyLoader