Skip to content

Adding selector for login shell in account settings #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 35 commits into from
Dec 16, 2022

Conversation

mckeags7
Copy link
Collaborator

No description provided.

@AryamanAgrawal AryamanAgrawal self-requested a review October 16, 2022 23:10
@hakasapl hakasapl linked an issue Oct 17, 2022 that may be closed by this pull request
@hakasapl hakasapl marked this pull request as draft October 17, 2022 19:18
@hakasapl hakasapl self-requested a review October 20, 2022 17:49
@hakasapl
Copy link
Collaborator

For the combobox:

<select>
    <option value="" disabled selected hidden>Select Login Shell...</option>
    <option value="hurr">Durr</option>
</select>

For the textbox:

Make it be hidden unless "custom" is selected in the combo box.

<input type=text placeholder="Enter custom login shell...">

@mckeags7 mckeags7 marked this pull request as ready for review November 9, 2022 21:08
@mckeags7 mckeags7 changed the title initial frontend changes to account.php Adding selector for login shell in account settings Nov 9, 2022
@hakasapl hakasapl marked this pull request as draft November 17, 2022 17:21
@mckeags7 mckeags7 marked this pull request as ready for review December 2, 2022 22:09
Copy link
Collaborator

@hakasapl hakasapl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor syntax fixes and added a suggestion to fix the issue where the textbox doesn't show up on page refresh if the user has a custom shell

mckeags7 and others added 8 commits December 14, 2022 10:33
Co-authored-by: Hakan Saplakoglu <hakansaplakog@gmail.com>
Co-authored-by: Hakan Saplakoglu <hakansaplakog@gmail.com>
Co-authored-by: Hakan Saplakoglu <hakansaplakog@gmail.com>
Co-authored-by: Hakan Saplakoglu <hakansaplakog@gmail.com>
Co-authored-by: Hakan Saplakoglu <hakansaplakog@gmail.com>
Co-authored-by: Hakan Saplakoglu <hakansaplakog@gmail.com>
Co-authored-by: Hakan Saplakoglu <hakansaplakog@gmail.com>
Co-authored-by: Hakan Saplakoglu <hakansaplakog@gmail.com>
Copy link
Collaborator

@hakasapl hakasapl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@hakasapl hakasapl merged commit f19317d into UnityHPC:main Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Invalid Login Shell
3 participants