Add ability to cancel request, require confirmation of account policy, fix dubious redirect #223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Required some changes to phpunit-bootstrap to allow GET parameters
Modified http_post/http_get for redirect and save previous $_SERVER
Added missing mail templates; made different one for group request
Cleanup string formatting
Co-authored-by: simonLeary42 <71396965+simonLeary42@users.noreply.github.com>
Co-authored-by: simonLeary42 <71396965+simonLeary42@users.noreply.github.com>
Require confirmation of account policy for PI requests
simonLeary42
changed the title
Use UnitySite::redirect instead of doing it ourselves
Move special logic from UnitySite::redirect to header.php
Fix PI checkbox being required by default
simonLeary42
changed the title
|
resolves #224 |
|
Can the EULA check box and the account policy check box work the same? EULA throws an error after submit, account policy throws error before submit. Ideally the submit button would also be grayed out until both are checked but that can be another PR. |
..err, I was wrong, they both make an error after submit. |
* add period * getNonExistentUser should be in htpasswd * move account policy checkbox down * rewrite * remove errors * remove debugging * fix autoload location * remove unnecessary redirect * revert unnecessary changes * phpcs * confirm account policy in test * post not get * agree not true * agree not true * add comments * revert
demo.mov |
|
|
simonLeary42
approved these changes
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify the new_account page to allow a user without an account to cancel a pending request for either a PI account or joining a group.