Skip to content

Commit 80762c7

Browse files
authored
Merge pull request #40 from sheldor1510/request-date
Adding request date to user/pi requests
2 parents 72b9599 + f1a1492 commit 80762c7

File tree

4 files changed

+18
-10
lines changed

4 files changed

+18
-10
lines changed

resources/lib/UnityGroup.php

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -329,7 +329,8 @@ public function getRequests()
329329

330330
$out = array();
331331
foreach ($requests as $request) {
332-
array_push($out, new UnityUser($request["uid"], $this->LDAP, $this->SQL, $this->MAILER));
332+
$user = new UnityUser($request["uid"], $this->LDAP, $this->SQL, $this->MAILER);
333+
array_push($out, [$user, $request["timestamp"]]);
333334
}
334335

335336
return $out;
@@ -361,9 +362,12 @@ public function getGroupMemberUIDs()
361362

362363
public function requestExists($user)
363364
{
364-
foreach ($this->getRequests() as $requester) {
365-
if ($requester->getUID() == $user->getUID()) {
366-
return true;
365+
$requesters = $this->getRequests();
366+
if (count($requesters) > 0) {
367+
foreach ($requesters as $requester) {
368+
if ($requester[0]->getUID() == $user->getUID()) {
369+
return true;
370+
}
367371
}
368372
}
369373

webroot/admin/pi-mgmt.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,7 @@
7070
<td>Name</td>
7171
<td>Unity ID</td>
7272
<td>Mail</td>
73+
<td>Requested On</td>
7374
<td>Actions</td>
7475
</tr>
7576

@@ -83,6 +84,7 @@
8384
echo "<td>" . $request_user->getFirstname() . " " . $request_user->getLastname() . "</td>";
8485
echo "<td>" . $request_user->getUID() . "</td>";
8586
echo "<td><a href='mailto:" . $request_user->getMail() . "'>" . $request_user->getMail() . "</a></td>";
87+
echo "<td>" . date("jS F, Y", strtotime($request['timestamp'])) . "</td>";
8688
echo "<td>";
8789
echo
8890
"<form action='' method='POST'>

webroot/panel/groups.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,7 @@
7171
echo "<td>" . $requested_owner->getFirstname() . " " . $requested_owner->getLastname() . "</td>";
7272
echo "<td>" . $requested_account->getPIUID() . "</td>";
7373
echo "<td><a href='mailto:" . $requested_owner->getMail() . "'>" . $requested_owner->getMail() . "</a></td>";
74+
echo "<td>" . date("jS F, Y", strtotime($request['timestamp'])) . "</td>";
7475
echo "<td></td>";
7576
echo "</tr>";
7677
}

webroot/panel/pi.php

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -60,18 +60,19 @@
6060

6161
foreach ($requests as $request) {
6262
echo "<tr>";
63-
echo "<td>" . $request->getFirstname() . " " . $request->getLastname() . "</td>";
64-
echo "<td>" . $request->getUID() . "</td>";
65-
echo "<td><a href='mailto:" . $request->getMail() . "'>" . $request->getMail() . "</a></td>";
63+
echo "<td>" . $request[0]->getFirstname() . " " . $request[0]->getLastname() . "</td>";
64+
echo "<td>" . $request[0]->getUID() . "</td>";
65+
echo "<td><a href='mailto:" . $request[0]->getMail() . "'>" . $request[0]->getMail() . "</a></td>";
66+
echo "<td>" . date("jS F, Y", strtotime($request[1])) . "</td>";
6667
echo "<td>";
6768
echo
6869
"<form action='' method='POST'>
6970
<input type='hidden' name='form_name' value='userReq'>
70-
<input type='hidden' name='uid' value='" . $request->getUID() . "'>
71+
<input type='hidden' name='uid' value='" . $request[0]->getUID() . "'>
7172
<input type='submit' name='action' value='Approve'
72-
onclick='return confirm(\"Are you sure you want to approve " . $request->getUID() . "?\")'>
73+
onclick='return confirm(\"Are you sure you want to approve " . $request[0]->getUID() . "?\")'>
7374
<input type='submit' name='action' value='Deny'
74-
onclick='return confirm(\"Are you sure you want to deny " . $request->getUID() . "?\")'>
75+
onclick='return confirm(\"Are you sure you want to deny " . $request[0]->getUID() . "?\")'>
7576
</form>";
7677
echo "</td>";
7778
echo "</tr>";

0 commit comments

Comments
 (0)