Skip to content

Adding request date to user/pi requests #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 8, 2022
Merged

Adding request date to user/pi requests #40

merged 4 commits into from
Dec 8, 2022

Conversation

sheldor1510
Copy link
Collaborator

hakasapl
hakasapl requested changes Dec 8, 2022
View reviewed changes
Copy link
Collaborator

@hakasapl hakasapl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Most looks good, just a minor question that I have

@hakasapl hakasapl linked an issue Dec 8, 2022 that may be closed by this pull request
Add the request date to user/PI requests on both PI and admin pages #36
Closed
@sheldor1510 @hakasapl
Update resources/lib/UnityGroup.php
f1a1492 
Co-authored-by: Hakan Saplakoglu <hakansaplakog@gmail.com>
@sheldor1510 sheldor1510 requested a review from hakasapl December 8, 2022 17:05
hakasapl
hakasapl approved these changes Dec 8, 2022
View reviewed changes
Copy link
Collaborator

@hakasapl hakasapl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you!

@hakasapl hakasapl merged commit 80762c7 into UnityHPC:main Dec 8, 2022
@sheldor1510 sheldor1510 deleted the request-date branch February 10, 2023 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hakasapl hakasapl hakasapl approved these changes

@AryamanAgrawal AryamanAgrawal Awaiting requested review from AryamanAgrawal

@mckeags7 mckeags7 Awaiting requested review from mckeags7

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add the request date to user/PI requests on both PI and admin pages
2 participants
@sheldor1510 @hakasapl