fix(q2): Xonotic with gametype CA #111
Conversation
Fix q2 parsing for Xonotic with gametype CA which has a leading float for damage not int for frags. Fixes #89
| if ((rc = sscanf(pkt, "%f %n", &frags_f, &len)) == 1) { | ||
| frags = (int)(frags_f*100); | ||
| } |
There was a problem hiding this comment.
could you simply not reset ping and instead skip the second sscanf by doing frags = (frags * 100) + ping (assuming ping is always going to be at most 2 decimal places, if it isn't, you could use a while loop to do an integer divide by ten to truncate it until the value was =< 99 and then add it, though at that point it's probably more complicated than a second sscanf)
There was a problem hiding this comment.
The decimals aren't limited to two, so as you say this is still the clearest way to do this.
There was a problem hiding this comment.
There is also that it may be that the decimal part of the number could not be loaded into a int, and in this case i believe sscanf would set ping to -1. So +1 to reloading with sscanf into a float
3 participants
Fix q2 parsing for Xonotic with gametype CA which has a leading float for damage not int for frags.
Fixes #89