Implementing step-to-catch for il2cpp debugger #760
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
joncham
reviewed
Dec 12, 2017
mono/mini/debugger-agent.c
Outdated
| @@ -4100,6 +4104,7 @@ thread_startup (MonoProfiler *prof, uintptr_t tid) | |||
| } | |||
| #ifdef IL2CPP_MONO_DEBUGGER | |||
| tls = il2cpp_gc_alloc_fixed(sizeof(DebuggerTlsData)); | |||
| tls->exception = NULL; | |||
There was a problem hiding this comment.
I am pretty sure il2cpp_gc_alloc_fixed sets everything to 0.
joshpeterson
approved these changes
Dec 12, 2017
joncham
approved these changes
Dec 12, 2017
|
@brianradunity Actually, I may have been wrong about it being zeroed. But, if it's not zeroed we should be memset'ing the whole structure not just the one field. |
mderoy
approved these changes
Dec 12, 2017
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.