Skip to content

[2021.3][mono][jit] Emit a null check when storing to valuetype fields. (#82663) #1783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 21, 2023
Merged

[2021.3][mono][jit] Emit a null check when storing to valuetype fields. (#82663) #1783

merged 1 commit into from
Jun 21, 2023

Conversation

jhcdunity3d
Copy link
Collaborator

@jhcdunity3d jhcdunity3d commented Jun 20, 2023 •
edited
Loading

  • [mono][jit] Emit a null check when storing to valuetype fields.

Fixes dotnet/runtime#82535.

Backport of #1781 to 2021.3

Parent Bug: UUM-27537
2021.3 Port: UUM-40141

[CleanGraft]

  • Should this pull request have release notes?
    • Yes
    • No
  • Do these changes need to be back ported?
    • Yes
    • No
  • Do these changes need to be upstreamed to mono/mono or dotnet/runtime repositories?
    • Yes
    • No

Reviewers: please consider these questions as well! ❤️

Release notes

Fixed UUM-27537 @UnityAlex :
Mono: Fixed crash when attempting to access a field of a null valuetype object.

@vargaz @jhcdunity3d
[mono][jit] Emit a null check when storing to valuetype fields. (#82663)
1ed7127 
* [mono][jit] Emit a null check when storing to valuetype fields.

Fixes dotnet/runtime#82535.

* Add a test.

* Disable the test on coreclr.
@unity-cla-assistant
Copy link
Collaborator

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@jhcdunity3d jhcdunity3d requested a review from UnityAlex June 21, 2023 16:17
@jhcdunity3d jhcdunity3d merged commit 5339cb9 into unity-2021.3-mbe Jun 21, 2023
@jhcdunity3d jhcdunity3d deleted the unity-2021.3-mbe-fix-uum-27537 branch June 29, 2023 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UnityAlex UnityAlex UnityAlex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jhcdunity3d @unity-cla-assistant @UnityAlex @vargaz