Implement multithreaded liveness checking #1418
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This branch introduces support for multithreaded liveness checking, and uses a new block container type, that will allocate new blocks when needed, instead of reallocating a continuous array like the old implementation did. This also removes the need for starting and stopping the world, and removing the marks that has been set in the walked objects.
|
@ashwinimurt to get notified when this is merged. |
joshpeterson
approved these changes
Mar 24, 2021
|
The changes look fine, but let's not merge this until we get the entire landing pattern with the IL2CPP and Unity repos worked out again. |
|
I'll make sure to run more than just abv this time, or perhaps we should make a dedicated batch for this. |
|
QV green unity branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a copy of a previous PR, that was backed out due to failing QV. The multithreading has been rewritten on the unity side, while the mono and il2cpp side remain the same
This branch introduces support for multithreaded liveness checking, and uses a new block container type, that will allocate new blocks when needed, instead of reallocating a continuous array like the old implementation did. This also removes the need for starting and stopping the world and removing the marks that has been set in the walked objects, when reallocating blocks for the array.