Add mono_unity_gc_set_mode API
#1302
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ono_unity_gc_disable`/`mono_unity_gc_is_disabled`
joncham
reviewed
Jun 2, 2020
| #endif | ||
| } | ||
|
|
||
| // Deprecated. Remove when Unity has switched to mono_unity_gc_set_mode |
There was a problem hiding this comment.
I'd prefer to not remove them too soon, as when we remove APIs I can't drop a new Mono into older unity (e.g. 2019.3).
joncham
approved these changes
Jun 2, 2020
UnityAlex
pushed a commit
that referenced
this pull request
Jul 17, 2020
…ono_unity_gc_disable`/`mono_unity_gc_is_disabled` (#1302)
UnityAlex
pushed a commit
that referenced
this pull request
Jul 31, 2020
…ono_unity_gc_disable`/`mono_unity_gc_is_disabled` (#1302)
UnityAlex
pushed a commit
that referenced
this pull request
Aug 14, 2020
…ono_unity_gc_disable`/`mono_unity_gc_is_disabled` (#1302)
UnityAlex
pushed a commit
that referenced
this pull request
Sep 24, 2020
…ono_unity_gc_disable`/`mono_unity_gc_is_disabled` (#1302)
UnityAlex
pushed a commit
that referenced
this pull request
Oct 30, 2020
…ono_unity_gc_disable`/`mono_unity_gc_is_disabled` (#1302)
UnityAlex
pushed a commit
that referenced
this pull request
Nov 13, 2020
…ono_unity_gc_disable`/`mono_unity_gc_is_disabled` (#1302)
UnityAlex
pushed a commit
that referenced
this pull request
Dec 22, 2020
…ono_unity_gc_disable`/`mono_unity_gc_is_disabled` (#1302)
UnityAlex
pushed a commit
that referenced
this pull request
Jan 29, 2021
…ono_unity_gc_disable`/`mono_unity_gc_is_disabled` (#1302)
UnityAlex
pushed a commit
that referenced
this pull request
Feb 5, 2021
…ono_unity_gc_disable`/`mono_unity_gc_is_disabled` (#1302)
UnityAlex
pushed a commit
that referenced
this pull request
Feb 12, 2021
…ono_unity_gc_disable`/`mono_unity_gc_is_disabled` (#1302)
UnityAlex
pushed a commit
that referenced
this pull request
Feb 22, 2021
…ono_unity_gc_disable`/`mono_unity_gc_is_disabled` (#1302)
UnityAlex
pushed a commit
that referenced
this pull request
Mar 16, 2021
…ono_unity_gc_disable`/`mono_unity_gc_is_disabled` (#1302)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to replace
mono_unity_gc_enable/mono_unity_gc_disable/mono_unity_gc_is_disabledThis will allow - beyond simply disabling the GC - to set the GC into "manual" mode, where GC is still possible (including incremental gc), but only when explicitly triggered. This allows content to take over managing collection frequency.