Skip to content

Avoid using StringBuilder marshaling Win32 (case 1211367). #1255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
douglas-piconi merged 1 commit into from
Feb 13, 2020
Merged

Avoid using StringBuilder marshaling Win32 (case 1211367). #1255

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions mcs/class/System/ReferenceSources/Win32Exception.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,9 @@ partial class Win32Exception
#if !MOBILE
[DllImport ("Kernel32", CharSet = CharSet.Unicode)]
static extern int FormatMessage(int dwFlags, IntPtr lpSource, uint dwMessageId, int dwLanguageId,
[Out] StringBuilder lpBuffer, int nSize, IntPtr[] arguments);
[Out] char[] lpBuffer, int nSize, IntPtr[] arguments);

const int MAX_MESSAGE_LENGTH = 256;
#endif

#if UNITY
Expand All @@ -26,15 +28,15 @@ internal static string GetErrorMessage (int error)
{
#if !MOBILE
if (Environment.IsRunningOnWindows) {
StringBuilder sb = new StringBuilder (256);
char[] messageArray = new char[MAX_MESSAGE_LENGTH];

int result = FormatMessage (0x1200 /* FORMAT_MESSAGE_IGNORE_INSERTS | FORMAT_MESSAGE_FROM_SYSTEM */,
IntPtr.Zero, (uint)error, 0, sb, sb.Capacity, null);
IntPtr.Zero, (uint)error, 0, messageArray, MAX_MESSAGE_LENGTH, null);

if (result == 0)
return "Error looking up error string";

return sb.ToString ();
return new string(messageArray);
}
#endif
#if UNITY
Expand Down