Fixes issue in mono_class_init where we would return immediately inst… #1249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ead of jumping to the cleanup routine. This would leave init_list in a dirty state for subsequent calls leading to recursive type definitions being thrown incorrectly. (case 1191002)
|
|
|
Nice. Can you open upstream PR as well? |
joncham
approved these changes
Jan 31, 2020
|
Yes I will open a pr for upstream as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ead of jumping to the cleanup routine. This would leave
init_listin a dirty state for subsequent calls leading to recursive type definitions being thrown incorrectly. (case 1191002)Release note:
Fix intermittent "TypeLoadException: Recursive type definition detected" that was being thrown on playmode start.