Handle locales with the same daylight savings time start and end #1220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the first and second transition DateTime objects are the same, `ValidateAdjustmentRule` will throw an exception. I'm unsure why these would be the same, but we do see that occur for some locales. In that case, just exit early. This change corrects Unity case 1160695.
joncham
approved these changes
Aug 23, 2019
|
I'll back port this to 2019.3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the first and second transition DateTime objects are the same,
ValidateAdjustmentRulewill throw an exception. I'm unsure why thesewould be the same, but we do see that occur for some locales. In that
case, just exit early.
This change corrects Unity case 1160695.
Release notes:
IL2CPP: Allow DateTime.Now to work properly on some non-English locales in WebGL. (case 1160695)