Update RSP with fault address for stack overflow (case 1148592) #1171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -151,6 +151,17 @@ LONG CALLBACK seh_vectored_exception_handler(EXCEPTION_POINTERS* ep) | |||
| switch (er->ExceptionCode) { | |||
| case EXCEPTION_STACK_OVERFLOW: | |||
| if (!mono_aot_only && restore_stack) { | |||
| if (er->NumberParameters == 2) { | |||
There was a problem hiding this comment.
What is the significance of the value 2 here? Can you add a comment with some details about that?
|
A few questions?
|
joshpeterson
approved these changes
Apr 30, 2019
|
Release Notes: No backporting I'll open PR for upstream. |
Use actual stack fault address rather than relying on the SP of the current frame. If we try to enter a method with a large prolog (many locals) we may try to allocate more stack than is available, however the SP has not been updated. This means the stack overflow heuristic to free up enough space may fail, as the used stack may be smaller than the amount of stack that was attempted to be unwound.
joncham
force-pushed
the
unity-master-stack-overflow-windows-sp-address
branch
from
e426d26 to
6ae9b7c
Compare
joshpeterson
approved these changes
May 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use actual stack fault address rather than relying on the
SP of the current frame. If we try to enter a method with a
large prolog (many locals) we may try to allocate more stack
than is available, however the SP has not been updated. This
means the stack overflow heuristic to free up enough space
may fail, as the used stack may be smaller than the amount
of stack that was attempted to be unwound.