Scripting memory capture static field byte reporting legacy bugfix #1081
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* uninitialized classes are also reported * added handling for class fields that are array type
looks like corrupted symbols as the 64bit address ends up getting downcasted to 32bit
*added missing include which caused the function signature to be int thus downcasting the pointer from 64 bit to 32
realek
commented
Nov 15, 2018
| @@ -11,7 +11,7 @@ | |||
| #include <libgc/include/gc.h> | |||
| #include <libgc/include/private/gc_priv.h> | |||
| #include <mono/metadata/gc-internal.h> | |||
|
|
|||
| #include <mono/metadata/mono-debug-debugger.h> | |||
There was a problem hiding this comment.
will probably need to check what happened to the definition of mono_vtable_get_static_field_data in mono 4.0 and if it needs the same include in here
realek
added a commit
that referenced
this pull request
Nov 16, 2018
*mirrored walking of all class fields from Mono 4.0 *added missing include which caused the function signature to be int for mono_vtable_get_static_field_data thus down casting the pointer from 64 bit to 32 bit and causing crashes
joncham
approved these changes
Nov 16, 2018
realek
added a commit
that referenced
this pull request
Nov 16, 2018
…ture_static_field_byte_reporting_legacy_bugfix_2018.3 [Backport][PR #1081] Scripting memory capture static field byte reporting legacy bugfix 2018.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*mirrored walking of all class fields from Mono 4.0 pr (#1065)
*added missing include which caused the function signature to be int for mono_vtable_get_static_field_data thus down casting the pointer from 64 bit to 32 bit and causing crashes (there might be some fog bugz cases related to this...I'll add them to the unity repo PR as I verify)