Use mono_mb_emit_op for CEE_LDOBJ to ensure wrapper data is added for… #1063
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshpeterson
approved these changes
Nov 2, 2018
|
Should we upstream this? It looks like the same code might be here now: https://github.com/mono/mono/blob/226a836210c1fc5ed7fc9ddc2fbca538b6711308/mono/metadata/marshal-ilgen.c#L1458-L1463 |
|
Yes, working on adding a test and upstream PR. |
… indirect load of a ref return value. (case 1096820)
joncham
force-pushed
the
unity-master-ref-return-struct
branch
from
2ebd672 to
3898ae1
Compare
|
Added test. Upstream PR: mono#11514 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… indirect load of a ref return value. (case 1096820)
The
mono_mb_emit_opcall caches the type data to be used later by method-to-ir