Hotfix - Visual observation memory leak #935
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| RenderTexture.active = prevActiveRT; | ||
| RenderTexture.ReleaseTemporary(tempRT); | ||
| return tex; | ||
| return texture2D; |
There was a problem hiding this comment.
Can you just pass texture 2D by reference? Use out Texture2D texture2D as method parameter.
There was a problem hiding this comment.
out assumes you will initialize within the function, which is explicitly what we don't want. I replaced it with a ref instead though.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the following memory leak bug: #930