update for trademark and consistency of ml-agents #916
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awjuliani
approved these changes
Jun 25, 2018
xiaomaogy
reviewed
Jun 27, 2018
There was a problem hiding this comment.
If you search the whole repo on keyword "ml-agents" (case insensitive), you can still find lots of place that we are using ML-Agents instead of ML-Agents Toolkit.
For example in README.md
If you have used a version of ML-Agents prior to v0.4, we strongly recommend our guide on migrating from earlier versions.
Are we also going to fix these?
xiaomaogy
reviewed
Jun 27, 2018
README.md
Outdated
| @@ -1,6 +1,6 @@ | |||
| <img src="docs/images/unity-wide.png" align="middle" width="3000"/> | |||
|
|
|||
| # Unity ML-Agents (Beta) | |||
| # Unity ML-Agents Tookit (Beta) | |||
awjuliani
reviewed
Jun 27, 2018
docs/Installation.md
Outdated
| @@ -16,9 +16,9 @@ _Linux Build Support_ component when installing Unity. | |||
| width="500" border="10" /> | |||
| </p> | |||
|
|
|||
| ## Clone the ml-agents Repository | |||
| ## Clone the Ml-Agents Toolkit Repository | |||
There was a problem hiding this comment.
This change is actually incorrect. The repository is literally called ml-agents.
awjuliani
reviewed
Jun 27, 2018
docs/Migrating.md
Outdated
| @@ -1,17 +1,17 @@ | |||
| # Migrating from ML-Agents v0.3 to ML-Agents v0.4 | |||
| # Migrating from the ML-Agents toolkit v0.3 to the ML-Agents toolkit v0.4 | |||
There was a problem hiding this comment.
We can probably word this more concisely as "Migrating from ML-Agents toolkit v0.3 to v0.4`
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.