Skip to content

Remove Discrete Observations #906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 25, 2018
Merged

Remove Discrete Observations #906

merged 5 commits into from
Jun 25, 2018

Conversation

awjuliani
Copy link
Contributor

@awjuliani awjuliani commented Jun 22, 2018

  • Remove discrete observations as separate category of vector observations. As such, there are now no discrete or continuous vector observations, only vector observations.
  • Environments which use discrete observations can now use AddVectorObs(index, range) in order to add one-hot vectors to the observations.
  • Modified documentation appropriately.
  • Changed Basic environment appropriately, and re-trained model.
  • Rebuilt protobuf definitions to reflect this change.
  • Upgrade protobuf to 3.6.0.

Copy link
Contributor

@xiaomaogy xiaomaogy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you do a ctrl+shift+f in the whole repo for keyword "discrete", there is still some places that mentions discrete observations.

For example:

In docs/Getting-Started-with-Balance-Ball.md:
The Discrete vector observation space is an index into a table of states.

In docs/Learning-Environment-Design-Agents.md:
For more information on CNNs, see this guide. You can use camera observations and either continuous feature vector or discrete state observations at the same time.

@awjuliani
Copy link
Contributor Author

Thanks for pointing this out @xiaomaogy. I have made the changes.

@awjuliani awjuliani merged commit 44e6647 into develop Jun 25, 2018
@awjuliani awjuliani deleted the develop-no-discrete-obs branch June 25, 2018 18:15
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants