Skip to content

Conversation

@Codengineer
Copy link
Contributor

@Codengineer Codengineer commented Jan 8, 2026

Dispose was not called in Academy when editor was quitting resulting in a crash in the Job system when CPU Workers were disposed in finalizers called from background threads (they need to be called on the Main thread)

By calling Dispose before tearing down the job system, CPU Workers are disposed properly the same way they are when you leave play mode.

Proposed change(s)

Added a Dispose action in Academy when Editor Application is quitting

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

@Codengineer Codengineer requested a review from maryamziaa January 8, 2026 20:01
@maryamziaa maryamziaa changed the title Bobd/crash on quit runmode Crash on quit runmode Jan 8, 2026
Dispose was not called when editor was quitting resulting in a crash in the Job system when CPU Workers were disposed in finalizers by the garbage collector on the wrong thread.
@Codengineer Codengineer force-pushed the bobd/crash_on_quit_runmode branch from d80582e to e3cfa5c Compare January 8, 2026 20:30
Updating PR number
@Codengineer Codengineer merged commit 76ce3f4 into develop Jan 9, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants