Skip to content

[debug] Require all behavior names to have a matching YAML entry (#5210) #5296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 22, 2021
Merged

[debug] Require all behavior names to have a matching YAML entry (#5210) #5296

merged 1 commit into from
Apr 22, 2021

Conversation

ervteng
Copy link
Contributor

@ervteng ervteng commented Apr 20, 2021 •
edited
Loading

Proposed change(s)

Cherry-pick of #5210 to release branch

(cherry picked from commit 86a4070)

Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

[debug] Require all behavior names to have a matching YAML entry (#5210)
76db0b9 
* Add strict check to settings.py

* Remove warning from trainer factory, add test

* Add changelog

* Fix test

* Update changelog

* Remove strict CLI options

* Remove strict option, rename, make strict default

* Remove newline

* Update comments

* Set default dict to actually default to a default dict

* Fix tests

* Fix tests again

* Default trainer dict to requiring all fields

* Fix settings typing

* Use logger

* Add default_settings to error

(cherry picked from commit 86a4070)
@ervteng ervteng requested a review from vincentpierre April 20, 2021 16:58
@ervteng ervteng merged commit 06488b0 into release_17_branch Apr 22, 2021
@delete-merged-branch delete-merged-branch bot deleted the release_17_behaviornames branch April 22, 2021 19:01
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vincentpierre vincentpierre vincentpierre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ervteng @vincentpierre